Newline problem

[thinice16]

I need help i cant figure out how to delete this newline without deleting it from the file if you know what i mean heres my code the problem is in the while loop.Because if i delete the newline right after fgets in the while loop all the text in the file will be horizontal no newlines.so yeah please help.

int createfile() {


    FILE *f;

    char filename[256];
    char filetext[2048];


    printf("File Name:");
    scanf("%s",filename);
    printf("[%s]",filename);
    if((f=fopen(filename,"w")) == NULL) {
       printf("Cannot open file %s.\n",filename);
       return 0;
    }
    printf("File %s opened for writing.",filename);

    printf("\n------------------------------------\n");

    while(1) {

       fgets(filetext,2048,stdin);
       printf("[%s]",filetext);
       if(strstr(filetext,"~")) {
          filetext[strlen(filetext) -2] = '\0';
          printf("[%s]",filetext);
          fprintf(f,"%s",filetext);
          break;
       }
       fprintf(f,"%s",filetext);
    }

    printf("File %s was created.\n",filename);
    fclose(f);

}

[MacGyver]

Check if there is a newline in the buiffer received with fgets(). Strip the newline if so. When you print it, if you had to strip it, then print an extra newline to the file.

[thinice16]

Should i do it like this?

while(1) {

       fgets(filetext,2048,stdin);
       filetext[strlen(filetext) -1] = '\0';
       printf("[%s]",filetext);
       if(strstr(filetext,"~")) {
          filetext[strlen(filetext) -2] = '\0';
          printf("[%s]",filetext);
          fprintf(f,"%s",filetext);
          break;
       }
       fprintf(f,"\n",filetext);
       fprintf(f,"%s",filetext);
    }

[MacGyver]

Why are you complicating this and doing it illogically?

fprintf(f,"%s\n",filetext);

Strip the newline with strchr(). Something like this (untested, btw, from memory):

char *ptr;

...

ptr = strchr(filetext, '\n');
if(ptr)
{
    *ptr = '\0';
}

[tabstop]

I would think you would want to print the data first, then the newline.

[Soham]

The following code also works

int createfile() {
    FILE *f;

    char filename[256];
    char filetext[2048];

    printf("File Name:");
    scanf("%s",filename);
    printf("[%s]",filename);
    if((f=fopen(filename,"w")) == NULL)
    {
        printf("Cannot open file %s.\n",filename);
        return 0;
    }
    printf("File %s opened for writing.",filename);

    printf("\n------------------------------------\n");

    while(1)
    {
        fgets(filetext,2048,stdin);
        filetext[strlen(filetext) -1] = '\0';
        printf("[%s]",filetext);
        filetext[strlen(filetext)] = '\n';
        if(strstr(filetext,"~"))
        {
            printf("[%s]",filetext);
            fprintf(f,"%s",filetext);
            break;
        }
        fprintf(f,"%s",filetext);
    }

    printf("File %s was created.\n",filename);
    fclose(f);

}

[Soham]

By mistake I preserved the ~ character in the file. Corrected in the following

int createfile() {
    FILE *f;

    char filename[256];
    char filetext[2048];

    printf("File Name:");
    scanf("%s",filename);
    printf("[%s]",filename);
    if((f=fopen(filename,"w")) == NULL)
    {
        printf("Cannot open file %s.\n",filename);
        return 0;
    }
    printf("File %s opened for writing.",filename);

    printf("\n------------------------------------\n");

    while(1)
    {
        fgets(filetext,2048,stdin);
        filetext[strlen(filetext) -1] = '\0';
        printf("[%s]",filetext);
        filetext[strlen(filetext)] = '\n';
        if(strstr(filetext,"~"))
        {
            filetext[strlen(filetext) -2] = '\0';
            fprintf(f,"%s",filetext);
            break;
        }
        fprintf(f,"%s",filetext);
    }

    printf("File %s was created.\n",filename);
    fclose(f);

}