Ok, thanks.
Ok, thanks.
gavra.
I just focused on the move function.
But you have two variables there. One is direction which is global. We cannot "follow" it exactly, but it is called "direction" and it is assigned to the board[][]. So we can understand what it means, since you also compare nicely the board with definitions UP, DOWN, LEFT, RIGHT.
The other is x which is global and passed to move. No idea what it does. Somebody will have to read the whole code to understand what it does.
As a rule, global variables should have a name to explain themselves. Even if you need a really long name to do that.
Anyhow, I liked your code, it was just difficult for someone else to debug itRecently I have written a 500 length code that was so messy that now I couldn't even understand it. But it works fine. And I was able to debug it when I was writing it because I remembered what everything did.
C isn't really easy to read. Actually it is hard. In order for a code in C to be readable you have to follow strickly some rules. Like mastp mentioned and as I mentioned above. On the other hand, you don't need to. If your code isn't meant to be shown or changed from a 3rd person then you can write it as it suits you.
Don't get me wrong. Your coding style isn't bad. You just have some details wrong, which as noted by mastp can cause bugs. When I enabled the -Wall option to compile it gave a lot of warnings. For my part, I couldn't read only the move() function and spot a bug, cause I had no idea what global variable x is suppose to do.
x is updated in the function "input()", and is the key pressed by the user - at least that's how I've interpreted it. But it is a good example of how you would get lost because of global variables [even with good names, but obviously x for "current input" is not a good name].
--
Mats
Compilers can produce warnings - make the compiler programmers happy: Use them!
Please don't PM me for help - and no, I don't do help over instant messengers.
I think it's my only "insignificant variable name".
It seems to be you havent noticed that I have already solved the problem - no one will have to read the whole code.
Have anyone here play my game? if so have you seen the cpu plays?
gavra.
I played it until the tail turned infinite. But I haven't played with the cpu (if that's what you mean).
Originally Posted by Adak
First of all take the move function from the previous page and replace with the old one.
Now I intended that you'll see the cpu plays not that you'll play with the cpu even though it doesn't sound a bad idea.
gavra.
I played it for quite long. When it was bugged. I liked it. There is a requirement for snake games that divides in good and bad. If they can make a really sharp turn. Yours pass
For the cpu haven't really seen it. I will though
Cool [:
If you want to see the cpu plays you musn't hit anykey for several seconds (7s I think).
There are some bugs with the cpu he is a fool one cause his lazy programmer dedicated only 5-10 minutes for writing his part XD
gavra.
Yeah, saw it. Well its a demo, so it's ok
Next step is to put graphics on your game. Since your at it
Shouldn't be very difficult and you can have your full own-made snake game.
I also mentioned some minor bugs. Like the fact that if you press any other key, except arrows or P, the head freezes, the tail follows its trail and ends on the head. So if you start again, hitting another key you have a small one-sized snake.
Also, when you press up and down on the menu sometimes the arrow doesn't fucntion right. Though this is really a small thing, don't even bother fixing it.
Yeah I have seen it.
It's not a big dill just a few seconds [:
I will add graphics but the only graphics that I know is "borlnad graphics" \:
I wrote about "allegro" but no relevant comments..
gavra.
Well, in java this would be done very easily. You would create window (JPanel, JFrame). Then a you would store your board[][] values in a specific place and call draw() which would update the window.
I suppose there are similar tools for C or at least C++. Maybe it can be done on WinAPI?
Don't know personally any tools...
JAVA AS C# is easy to work with especially with graphics (this ".net" ruins our world!).
There is but the problem is that API isn't simple and creating a "quality" graphics in C is a long hard labor \:
so borland graphics may be enough for lazy programmers like me :]
What do you know about "forms in C" ?
gavra.
Tell me something funny dude have you read my last post?
gavra.
I read it. You said Borland graphics was going to be enough for this program.
I posted a program that used Borland graphics. I have no idea wtf amuses you, but your attitude is somewhat odd for someone who has received so much help, here.
I guess I can delete the program as easily as I posted it.
Now that's funny.
Admittedly, graphics aren't easy in C. Mostly because of the poor API functions available to do so, and partly because it's... well, C.
But there's no easy way in C++ either due to a lacking easy-to-use framework for doing such.
But this is C, not C++, or Java.
