Help with if statement comparing a Char

Code:

if(publisher>=pub1loop && publisher<=pub2loop){
				ret = 1;/*return 1 if the publisher sents falls between*/		
			}

i think this is where my problem is, because ret is never setting to 1

example i send in "70002" <- publisher char

and pub1loop equals "70000" and pub2loop equals "79999"

this is my full function:

Code:

int registered(FILE* fp, int area, const char* publisher){
    	int pub1loopint, pub2loopint, ret=0;
    	char pub1loop[7], pub2loop[7], arealoop[7], areatostring[7];
    	sprintf(areatostring, "%i", area);
    	rewind(fp);
    	while(!feof(fp)) {
		fscanf(fp, "%s %c %c", arealoop, pub1loop, pub2loop);
		if(strcmp(areatostring,arealoop)==0){/*do this when the two areas are the same*/	
			pub1loopint = atoi(pub1loop);
			pub2loopint = atoi(pub2loop);	
			if(publisher>=pub1loop && publisher<=pub2loop){
				ret = 1;/*return 1 if the publisher sents falls between*/		
			}
		}
    	}
    	return ret;
}

> fscanf(fp, "&#37;s %c %c", arealoop, pub1loop, pub2loop);
Use %s, not %c to read into a string.

And strings are compared with either strcmp() or strncmp(), like you did here:
if(strcmp(areatostring,arealoop)==0){/*do this when the two areas are the same*/

And it seems you could actually make arealoop an int. Then you could compare area directly with arealoop, without converting area first.

http://cpwiki.sourceforge.net/Common..._the_right_way

Originally Posted by swoopy

> fscanf(fp, "%s %c %c", arealoop, pub1loop, pub2loop);
Use %s, not %c to read into a string.

And strings are compared with either strcmp() or strncmp(), like you did here:
if(strcmp(areatostring,arealoop)==0){/*do this when the two areas are the same*/

And it seems you could actually make arealoop an int. Then you could compare area directly with arealoop, without converting area first.

it was %s before but i changed it to see if that'll work

and if i use strcmp how do i find if it between pub1loop and pub2loop

Make publisher an int first!
Like:
intPublisher = atoi(publisher);

Apart from that it seems correct.
If the above doesn't work, printf() some variables, like pub1loopint, pub2loopint to see if you get the correct data

Don't use atoi; use strtol.

>and if i use strcmp how do i find if it between pub1loop and pub2loop
Here's what you have now:

Code:

			if(publisher>=pub1loop && publisher<=pub2loop){

So try something like:

Code:

			if (strcmp(publisher, pub1loop) >= 0 && strcmp(publisher, pub2loop) <= 0 ) {

And as suggested, if the value of publisher is 9 digits or less and won't contain leading zeros, you could use a long and forget about using a string comparison.