Thread: Linked list problem

I get this problem where I am copying words into a list as words are entered. Essentially everytime a word is entered, I create a node and link that into the list.

At the end, I print out the list, but for some reason I only get the last word that I entered printing, several times.

Code:

list print () {

  list current = head;
  while(current != NULL) {
    printf("%s\n", current->string);
    current = current->next;
  }
  return (head);
}

void list (char *input) {

  list node;

  node = makeN();
  
  if(head == NULL) {
    head = node;
    tail =node;
    head->string= input;
    tail->string = input;
  }
  
  else {
    tail->next = node;
    tail = tail->next;
    tail->word = input;
  }


}

My head and tail are globals

Without reading the code I can tell you that you are storing the address of the string entered. You need to copy the string into the linked list. You can either have a fixed size array or allocate memory dynamically according to the length of the word [and remember to make space for the zero at the end of the word].

--
Mats

Ah, hehe, that worked =)

THANKS!