fscanf for multi dimensional arrays

i am trying to take a line from a text file using fscanf
the textfile looks like this:

before and after % whiteny houston texas
on the map % Lake Arrowhead California
(etc for 46 lines)

Code:

FILE *inp;
inp = (FILE *) fopen("clues.txt", "r");
int row, column;
char clue[row][column]
for(row = 0; row <= 46; ++row)
{
for(column = 0; column <= 60; ++column)
{
fscanf(inp, "%s", &clue[i]);
}
}
printf("%s", *clue); 
}

We need to get each line into a seperate line of the array right now it only prints one word and seems to only be putting one word from a random line into the array.

Code:

int row, column;
char clue[row][column]

this is not a way to declare array - dimmentions should be constants

%s reads till the first whitespace
%[^\n] reads till the newline

We have changed everything that you said and it now reads and prints the first line of the file but how would we get it to read all the lines into the array?

Originally Posted by rambos

We have changed everything that you said and it now reads and prints the first line of the file but how would we get it to read all the lines into the array?

Using loop?

Code:

FILE *inp;
inp = (FILE *) fopen("clues.txt", "r");
int row, column;
char clue[row][column]
for(row = 0; row <= 46; ++row)
{
for(column = 0; column <= 60; ++column)
{
fscanf(inp, "%s", &clue[i]);
}
}
printf("%s", *clue); 
}

i, undecleared

Whoops, Im working with rambos on this project and he just copied it wrong that i is actually "row".

Hmm.

> FILE *inp;
> inp = (FILE *) fopen("clues.txt", "r");

There shouldn't be a reason to cast the return types of these functions unless you've neglected to include the necessary header file <stdio.h>. I'd just include that and not worry about the return type.

> int row, column;
> char clue[row][column]
> for(row = 0; row <= 46; ++row)
> {

There's a couple of things weird with this declaration. It appears like you want to build an array of a specific size, but in fact you don't do that at all. You instead use row and column to run the loop.

> for(column = 0; column <= 60; ++column)
> {
> fscanf(inp, "&#37;s", &clue[i]);
> }
> }

That will never quite run the way it should. If you're going to loop through every row of every column you should be reading characters instead of strings.

Apart from the syntax errors, these are the big things that worried me. Lemme see if I could guess at what you really wanted here:

Code:

#include <stdio.h>
#include <stddef.h> /** for size_t **/

/** example: **/

int main (void)
{
    char clues[40][60];
    size_t i = 0;
    FILE * inp = NULL;

    inp = fopen("clues.txt", "r");

    if (inp != NULL) {
       for (i = 0; i < sizeof clues / sizeof clues[0]; i++) {
          fscanf(inp, "%59s", clues[i]);
       }
       for (i = 0; i < sizeof clues / sizeof clues[0]; i++) {
          printf("%s\n", clues[i]);
       }
       fclose(inp);
    }
    return 0;
}

clues[i] is the same type of thing as &clues[i][0].
Something like that ought to work okay, though I only got a compile. Testing it is your problem.

Note how citizen specifies the size to fscanf to avoid a buffer overrun. More information here:
http://cpwiki.sourceforge.net/Buffer_overrun