Thread: Linked list acting as string

response is an array, and therefore doesn't have any member functions. If you mean std::string (which has a length function) then say so. If you need to use a char array, then go with sizeof. EDIT: Not C++, so ignore the std::string thing, and go with sizeof.

I fixed my previous code, but now when I try and add a separate method it no longer works again.

Code:

#include <stdio.h>
#include <stdlib.h>			


struct node {				
	char data;
	struct node *next;
};

int menu();					
struct node *insert(struct node *, char);	


void main()
{
	struct node *front;		
	int optionsResponse;
	char response[9999];	
	front = NULL;			
	do				
	{				
		optionsResponse = menu();
		switch(optionsResponse) 
		{
			case 1 : 
					printf ("Enter a new string:  ");	// insert new datum
					scanf("&#37;s", &response);
					front = insert(front, response);
					printf("\n");
					break;
		}
	} while(optionsResponse != 8);
}

int menu()	
{
	int temp;
	printf("Please select from one of the following String menu options: \n\n");
	printf("1.\tCreate a new string\n");
	printf("8.\tQuit\n\n");
	printf("I choose option number: ");
	scanf("%d", &temp);
	return temp;
}


struct node *insert(struct node *f, char *response[])
{ 
	struct node *front, *temp;		
	int i = 0;
	

	front = malloc(sizeof(struct node));							
	front->data = response[i++];											
	front->next = NULL;					
	temp = front;													

	
	while(response[i] != NULL)													
	{
		temp->next = malloc(sizeof(struct node));					
		temp = temp -> next;										
		temp->data = response[i++];									
		temp->next = NULL;
	}

	printf("List currently contains:  ");
	while(f != NULL)
	{
		printf("%c", f->data);
		f=f->next;
	}
	printf("\n");
}

What am i doing wrong?

A 'f=front;' is missing between the insertion part and the final printf part, I think.

It won't be sufficient to correctly return the result though (as the
front in main won't be modified).

After adding f = front, I get the first node to print correctly but all/most after do not correctly print.

I am not sure what you mean about the buffer overrun. I added a print method but for some reason, now my program crashes when I want to print out the linked list. I also think my previous code was destroying my nodes when I entered a new string instead of tacking it on to the end of my first string. How can I fix these errors?

Also - thank you to everyone who has helped me despite my annoying newbie problems.

Code:

#include <stdio.h>
#include <stdlib.h>			


struct node {				
	char data;
	struct node *next;
};

int menu();					
struct node *insert(struct node *, char);
void print(struct node *);


void main(void)
{
	struct node *front;		// front points to the front of our list
	int optionsResponse;
	char response[25];	// user inputs
	int index = 0;
	int index2 = 0;
	front = NULL;			// initialize list to NULL
	do				// display menu, do command, quit when user inputs choice 8
	{				
		optionsResponse = menu();
		switch(optionsResponse) 
		{
			case 1 : 
					printf ("Enter a new string:  ");	// insert new datum
					scanf("%s", response);
					front = insert(front, response);
					printf("\n");
					break;
			case 2 :
					print(front);
					break;
		}
	} while(optionsResponse != 8);
}

int menu()	// display menu and get user's choice
{
	int temp;
	printf("Please select from one of the following String menu options: \n\n");
	printf("1.\tCreate a new string\n");
	printf("2.\tPrint the linked list\n");
	printf("8.\tQuit\n\n");
	printf("I choose option number: ");
	scanf("%d", &temp);
	return temp;
}


struct node *insert(struct node *f, char *response)
{ 
	struct node *front, *temp;		
	int i = 0;

		front = malloc(sizeof(struct node));							
		front->data = response[i++];
		front->next = NULL;					
		temp = front;
	
	while(response[i] != '\0')													
	{
		temp->next = malloc(sizeof(struct node));					
		temp = temp -> next;										
		temp->data = response[i++];
		temp->next = NULL;
	}

	return temp->data;
}

void print(struct node *f)
{
	printf("List currently contains:  ");
	while(f != NULL)
	{
		printf("%c", f->data);
		f=f->next;
	}
	printf("\n");
}

I am trying a new approach since my last post, and I am not sure if the logic is right or why my syntax is incorrect.

Code:

#include <stdio.h>
#include <stdlib.h>			


struct node {				
	char data;
	struct node *next;
};

int menu();					
struct node *insert(struct node *, char);
void print(struct node *);


void main(void)
{
	struct node *front;	
	int optionsResponse;
	char response[25];	
	front = NULL;			
	do				
	{				
		optionsResponse = menu();
		switch(optionsResponse) 
		{
			case 1 : 
					printf ("Enter a new string:  ");	
					scanf("%s", response);
					front = insert(front, response);
					printf("\n");
					break;
			case 2 :
					print(front);
					break;
		}
	} while(optionsResponse != 8);
}

int menu()	
{
	int temp;
	printf("Please select from one of the following String menu options: \n\n");
	printf("1.\tCreate a new string\n");
	printf("2.\tPrint the linked list\n");
	printf("8.\tQuit\n\n");
	printf("I choose option number: ");
	scanf("%d", &temp);
	return temp;
}


struct node *insert(struct node *f, char response)
{ 
			
	int i = 0;
	struct node *temp = (struct node *)malloc(sizeof(struct node)), *previous, *current;
	temp->data=response[i++];
	temp->next=NULL;

	while (response[i] != '\0')
	{
		if (f == NULL)
		{
			return temp;
		}
		else {

				current = f;
				while(current != NULL)													
				{
					previous=current;
					current=current->next;
				}
				previous->next=temp;	
				temp->next=current;
				temp->data = response[i++];
				return temp;
			}
	}

	
}

void print(struct node *f)
{
	printf("List currently contains:  ");
	while(f != NULL)
	{
		printf("%c", f->data);
		f=f->next;
	}
	printf("\n");
}

My errors are on lines:

Code:

temp->data=response[i++];
while (response[i] != '\0')
temp->data = response[i++];

and I get the error:
subscript requires array or pointer type

Was I better off the way I had it? What do I need to correct?

Code:

struct node *insert(struct node *f, char response)

needed to be:

Code:

struct node *insert(struct node *f, char *response)

And it fixed that error, but I still have a logic error where it only puts the first character of my char array into the first node, and doesn't put my next character in the array in my next node(which it's supposed to do until my char array points at '\0')

How do i return everything in the linked list rather than having to return each individual node?

I was able to fix my prior questions, but I am trying to create 3 char arrays and place each character into a node with a null node to separate each word.

Code:

#include <stdio.h>
#include <stdlib.h>			


struct node 
{				
	char data;
	struct node *next;
};

int menu();					
struct node *addString(struct node *, char *);
void print(struct node *);


void main(void)
{
	struct node *front;	
	int optionsResponse;
	char response[25];	
	front = NULL;			
	do				
	{				
		optionsResponse = menu();
		switch(optionsResponse) 
		{
			case 1 : 
					printf ("Enter a new string:  ");
					scanf("%s", response);
					front = addString(front, response);
					printf("\n");
					break;
			case 2 :
					print(front);
					break;
		}
	} while(optionsResponse != 8);
}

int menu()
{
	int temp;
	printf("Please select from one of the following String menu options: \n\n");
	printf("1.\tCreate a new string\n");
	printf("2.\tPrint the linked list\n");
	printf("8.\tQuit\n\n");
	printf("I choose option number: ");
	scanf("%d", &temp);
	return temp;
}


struct node *addString(struct node *f, char *response)
{ 	
	int i = 0;
	struct node *temp = (struct node *)malloc(sizeof(struct node));
	struct node *front = temp;

	temp->data=response[i++];
	temp->next=NULL;
	
	while(response[i] != '\0')													
	{
		temp->next = (struct node *)malloc(sizeof(struct node));					
		temp = temp -> next;										
		temp->data = response[i++];
		temp->next = NULL;
	}

	return front;

}

void print(struct node *f)
{
	printf("List currently contains:  ");
	while(f != NULL)
	{
		printf("%c", f->data);
		f=f->next;
	}
	printf("\n");
}

But my code only prints the last created char array and not all the char arrays I have added to the linked list. Where is my logic error?

Code:

...
front = addString(front, response);
...

You only record the head of the last linked list.
Try to initialize 'front' only once to get everything.