Improving Code Interface

Hi,
I was wondering if someone would be willing to help me improve my code's interface its for a wheel of fortune/hangman type game. I won't post the whole code right now, but I just was wondering if there was anyone out there who would be interested. Thanks.

People will generally read posts and reply with comments here.

Maybe if we could see the code we could help you. Are you trying to make it work better or are you trying to make it look better?

Yes, we are very critical.

Would it be okay if I posted the code? Because a while back I posted a whole code and I kind of got scolded for it....

Well, you'll get told off for posting a whole load of code with no particular good question (or you have a question which clearly relates to 5 lines, and you post 500 lines just because you have 500 lines of code).

If you ask for a "code review", then you would need to post the pieces of code that you want reviewed and anything relating to that (e.g. data structures, type declarations and such).

It is quite a task to review hundreds of lines of code, tho'.

--
Mats

> It is quite a task to review hundreds of lines of code, tho'.
And it doesn't really help IMHO.

For example if someone did up your car totally, everything you could think of -- you'd probably notice it's better but not know in detail how. You'd be overwhelmed by the changes, having learnt nothing. And asked to do the same to another car, you'd have no idea.

Rather, "this is what we'll do here, and how we'll do it".

Originally Posted by helloamuro

Hi,
I was wondering if someone would be willing to help me improve my code's interface its for a wheel of fortune/hangman type game. I won't post the whole code right now, but I just was wondering if there was anyone out there who would be interested. Thanks.

That means you wanted to improve on GUI part (if there is any GUI), well, post a screen shot!

Or the API ... Not really GUI. interface can mean many things.

Sorry, I should clarify myself more. By interface I meant how the program looks when it runs. Below I have posted two functions (whose meanings are obvious from their titles). I think that to center everything correctly field widths need to be used. Please forgive me if this is a simple question; I'm currently a beginning C student and I only know the simple basics.

Code:

void print_puzzle (int size, char puzzle[], char clue[])
{
	int i;
	printf("===============================\n");
	printf("Puzzle\n");
	printf("%s\n", clue); /*prints clue*/
	printf("===============================\n\n"); 
	for (i = 0; i < size; ++i){
		printf("%c",puzzle[i]); /*prints word hidden*/
		}
	printf("\n\n===============================\n\n");
}

void print_score(int players, int score[])
{
	int p;
	printf("\n");
	for (p = 0; p < players; ++p){
		printf("Player %d ", p+1); /*prints player numbers*/
		}
	
	printf("\n");
	
	for (p = 0; p < players; ++p){
		printf("======== ");
		}
	
	printf("\n");
 
	for (p = 0; p < players; ++p){
		printf(" %d ", abs(score[p])); /*prints each players score*/
		}
	
	printf("\n\n");
}

Do you have any idea what it should look like?

Just a warning that dolling up your command line programs may not be worth it. Look at your keyboard right now. That's all the keys you can type portably without needing wider streams or multibyte characters. If you start printing obscure characters to draw boxes or something, then your code becomes more non-portable. That's not a good thing if you're in uni.

Please post a screen shot.

Here is a screenshot. Sorry about the eraser, there was some personal info down there. I need the program to somehow print in the middle of a 40 row by 80 column screen. Any help is appreciated. Others are displayed, but I don't feel comfortable posting them all unless someone is willing to help me via email. Thanks again.
Here are the main functions displayed:

Code:

void print_puzzle (int size, char puzzle[], char clue[], int round)
{
	int i;
	printf("                                      ===============================\n");
	printf("                                                  Round %d\n", round+1);
	printf("                                      ===============================\n\n"); 
	printf("Clue: %s\n\n", clue); /*prints clue*/
	for (i = 0; i < size; ++i){
		printf("%2c",puzzle[i]); /*prints word hidden*/
	}
	printf("\n\n");

}

void print_score(int players, int score[])
{
	int p;
	printf("\n");
	for (p = 0; p < players; ++p){
		printf("      Player %d ", p+1); /*prints player numbers*/
		}
	
	printf("\n");
	
	for (p = 0; p < players; ++p){
		printf("      ======== ");
		}
	
	printf("\n");
 
	for (p = 0; p < players; ++p){
		printf("        $%d     ", abs(score[p])); /*prints each players score*/
		}
	
	printf("\n\n");
}




int player_turn(int player_num, int player, int score[], char phrase[], char puzzle[], char clue[], int size, int round){
	
	int solved = 0; /*solve is initialized to zero to indicate puzzle has not been solved*/
	char player_continues = 1;
	char options[10]; /*string to hold choice*/

	while (player_continues == 1){
		char choice = ' '; /*choice initialized to nothing*/
		print_score(player_num, score);
		print_puzzle(size, puzzle, clue, round);
		printf("Player %d, what do you want to do?\n\n", player+1);
		while (choice != 'S' && choice != 'O' && choice != 'B') {
			printf("(S)pin, S(o)lve or (B)uy a vowel -> ");
			if(fgets(options,10,stdin))
				{
					sscanf(options, "%c", &choice); /*player types in choice and it is stored in options*/
				}

			choice = to_upper(choice); /*converts choice to uppercase to prevent case sensitivity*/
			printf("\n");
			}
		if (choice == 'S'){ /*if player chooses spin*/
			player_continues = spin(player, score, phrase, puzzle, size);
			}
		else if (choice == 'O'){ /*if player chooses solve*/
			solved = solve(player, score, phrase, size, clue, round);
			player_continues = 0;
			}
		else /* buy a vowel */{
			player_continues = buy_vowel(player, score, phrase, puzzle, size);
			}
		}
	return solved;
}

I should also mention that I would like to know how to clear the screen once a player has chosen a letter and that letter is revealed. Thanks

FAQ > How do I... (Level 1) > Clear the screen?