Replacing Characters

How am I doing this wrong. It seems to be replacing my whole string with either \' or spaces.

Code:

---

        for (i = 0; i < sizeof(id3v1.artist); i++)
        {
                if (strcmp(id3v1.artist + i, "\"") == TRUE)
                {
                        memcpy(id3v1.artist + i, "\'", sizeof(char));
                }
        }

---

My struct looks like this

Code:

---

struct id3v1
{
        char title[30];
        char artist[30];
        char album[30];
        char year[4];
        char comment[30];
        BYTE genre;
}        id3v1;

---

Quote:

---

memcpy(id3v1.artist + i, "\'", sizeof(char));

---

should be:

Quote:

---

memcpy(id3v1.artist + i, "\"", sizeof(char));

---

strcmp does not returns TRUE or FALSE

strcmp used to compare strings not chars

Code:

---

if (id3v1.artist[i] == '\"')
{
        id3v1.artist[i] = '\'';
}

---

something like that should work better for replacing 1 char

> for (i = 0; i < sizeof(id3v1.artist); i++)
In addition to the other comments, strlen() might be more appropriate here:

Code:

---

        size_t len = strlen(id3v1.artist);
        for (i = 0; i < len; i++)

---