strtok problem again

hello, i have the following code... in order to resolve strtok problem, i made a duplicate copy of cmdList named cmdListDup and did a strtok on cmdListDup instead... why am i still getting a modified cmdList after the last loop? :/

Code:

/* concatenate command and get command count */
	for(i = 0; i < cmdWords; i++) {
		strcat(cmdStr, words[i]);
		strcat(cmdStr, " ");
		if(strcmp(words[i], "|") == 0 ) {
			cmdCount ++;
		}
	}
	/* Remove | */
	temp = strtok(cmdStr, "|");
	i = 0;
	while(temp) {
		cmdList[i] = temp;         
		cmdListDup[i] = temp; /* duplicate of cmdlist */
		temp = strtok(NULL, "|");
		i++;
	}
	
	printf("cmd b4 forloop:&#37;s\n", cmdList[0]);  //prints cmd b4 forloop: hello -a
	/* get command for each commands */
	for(i = 0; i <= cmdCount; i++) {
		temp = strtok(cmdListDup[i], " ");
		cmd[i] = temp;
		printf("cmd:%s\n", cmd[i]);
	}
       printf("cmd after forloop:%s\n", cmdList[0]); //prints cmd afer forloop: hello

Originally Posted by cstudent

hello, i have the following code... in order to resolve strtok problem, i made a duplicate copy of cmdList named cmdListDup and did a strtok on cmdListDup instead... why am i still getting a modified cmdList after the last loop? :/

Code:

/* concatenate command and get command count */
	for(i = 0; i < cmdWords; i++) {
		strcat(cmdStr, words[i]);
		strcat(cmdStr, " ");
		if(strcmp(words[i], "|") == 0 ) {
			cmdCount ++;
		}
	}
	/* Remove => */
	temp = strtok(cmdStr, "|");
	i = 0;
	while(temp) {
		cmdList[i] = temp;
		cmdListDup[i] = temp;
		temp = strtok(NULL, "|");
		i++;
	}
	
	printf("cmd b4 forloop:%s\n", cmdList[0]);  //prints cmd b4 forloop: hello -a
	/* get command for each commands */
	for(i = 0; i <= cmdCount; i++) {
		temp = strtok(cmdListDup[i], " ");
		cmd[i] = temp;
		printf("cmd:%s\n", cmd[i]);
	}
       printf("cmd after forloop:%s\n", cmdList[0]); //prints cmd afer forloop: hello

A better questing is, why are you talking about using strtok on cmdList, when you're using it on cmdStr? Also, you're not assiging cmdList[i] to temp, you are assigning temp to cmdList[i] - e.g. the opposite.

Originally Posted by IceDane

A better questing is, why are you talking about using strtok on cmdList, when you're using it on cmdStr? Also, you're not assiging cmdList[i] to temp, you are assigning temp to cmdList[i] - e.g. the opposite.

why am i assigning the values to temp instead? i dun understand

Originally Posted by cstudent

why am i assigning the values to temp instead? i dun understand

Nevermind what I said, I misunderstood the code, mainly because you didn't post the whole code.

Post the whole code and we'll be able to help you.

i edited the code to the following and its working.

Code:

/* concatenate command and get command count */
	for(i = 0; i < cmdWords; i++) {
		strcat(cmdStr, words[i]);
		strcat(cmdStr, " ");
		if(strcmp(words[i], "|") == 0 ) {
			cmdCount ++;
		}
	}
	/* Remove => */
	temp = strtok(cmdStr, "|");
	i = 0;
	while(temp) { 
                cmdList[i] = (char*)malloc(1000);           /* allocate memory */
                cmdListDup[i] = (char*)malloc(1000);    /* allocate memory */
		strcpy(cmdList[i], temp);
                strcpy(cmdListDup[i], temp);
		temp = strtok(NULL, "|");
		i++;
	}
	
	printf("cmd b4 forloop:&#37;s\n", cmdList[0]);  
	/* get command for each commands */
	for(i = 0; i <= cmdCount; i++) {
		temp = strtok(cmdListDup[i], " ");
		cmd[i] = temp;
		printf("cmd:%s\n", cmd[i]);
	}
       printf("cmd after forloop:%s\n", cmdList[0]);

There is something dubious about that while(temp) loop to me.... You may want to rethink your memory allocation strategy a bit... Things like that usually have a lot of room for memory leaks and just general system resource draining. But, whatever tickles your pickle bud.

Or try my own strtok instead of making duplicates. It's up to you, but I find it far better than having to worry about freeing allocated memory.