Problem with nested loops in functions

This is a discussion on Problem with nested loops in functions within the C Programming forums, part of the General Programming Boards category; I am absolutely stumped on what I am doing wrong here. Essentially I have a function that takes a two ...

  1. #1
    Registered User
    Join Date
    Apr 2008
    Posts
    19

    Problem with nested loops in functions

    I am absolutely stumped on what I am doing wrong here. Essentially I have a function that takes a two dimensional array of chars and tries to determine if there are five "x" chars in a row. Here is the function:

    Code:
    int wincheck1 ( char b[][COLS] )
    {
    	int i, j, WIN;
    
    	
    	for( i=0; i < ROWS; i++ ){
    		if(WIN == 1)
    			break;
    		else{
    		for ( j=1; j < (COLS-4); j++ ){
    	
    			if( b[i][j] != b[i][j+1] != b[i][j+2] != b[i][j+3] != b[i][j+4] != 'x' ){
    				WIN=0;
    			}
    			else{
    				WIN=1;
    				break;
    			}
    		}
    	}
    	}
    
    	return WIN;
    
    
    }
    It appears that this code always returns 0 even when I set up the array with 5 or more x chars in a row. I have done all kinds of tinkering with this code, but it always returns zero or goes into an infinite loop, never doing what I would like. Please help.

    EDIT: ignore the fact that rows start at zero and columns start at 1. That's just the way that I set up the array.

    EDIT: I originally tried to put a return statement after WIN=1 in place of using break statements, but that was giving me the same headaches.
    Last edited by countchocula; 04-21-2008 at 12:36 PM.

  2. #2
    Banned master5001's Avatar
    Join Date
    Aug 2001
    Location
    Visalia, CA, USA
    Posts
    3,685
    Could I see the code that calls this function too, please. I am not a fan of multidimensional arrays by the way... And one doesn't have to be a calculus professor to just do the math and make it single dimensional, but that is just me being picky...

    And at first glance of your code, it doesn't always go into the second for loop. Which is probably where you are having issues, right?

    Code:
    int wincheck1 ( char b[][COLS] )
    {
    	int i, j, WIN;
    
    	
    	for( i=0; i < ROWS; i++ ){
    		if(WIN == 1)
    			break;
    		else{
    		for ( j=1; j < (COLS-4); j++ ){
    	
    			if( b[i][j] != b[i][j+1] != b[i][j+2] != b[i][j+3] != b[i][j+4] != 'x' ){
    				WIN=0;
    			}
    			else{
    				WIN=1;
    				break;
    			}
    		}
    	}
    	}
    
    	return WIN;
    
    
    }
    WIN's value is by default "undefined."
    Last edited by master5001; 04-21-2008 at 12:44 PM.

  3. #3
    Algorithm Dissector iMalc's Avatar
    Join Date
    Dec 2005
    Location
    New Zealand
    Posts
    6,304
    Quote Originally Posted by countchocula View Post
    if( b[i][j] != b[i][j+1] != b[i][j+2] != b[i][j+3] != b[i][j+4] != 'x' )[/code]
    That will not do anything close to what you want!
    You'd need to seperate each expression, comparing each element with 'x', and &&ing the results together to make that work.
    Or better yet, make it into another loop.
    My homepage
    Advice: Take only as directed - If symptoms persist, please see your debugger

    Linus Torvalds: "But it clearly is the only right way. The fact that everybody else does it some other way only means that they are wrong"

  4. #4
    Registered User
    Join Date
    Apr 2008
    Posts
    19
    Quote Originally Posted by iMalc View Post
    That will not do anything close to what you want!
    You'd need to seperate each expression, comparing each element with 'x', and &&ing the results together to make that work.
    Or better yet, make it into another loop.

    Haha brilliant! I was worried about that section. I will try it out and get back to you.



    EDIT:

    Wow it worked. I can't believe I overlooked that portion of code. it seems so obvious now. Thanks!
    Last edited by countchocula; 04-21-2008 at 02:22 PM.

  5. #5
    Banned master5001's Avatar
    Join Date
    Aug 2001
    Location
    Visalia, CA, USA
    Posts
    3,685
    I don't think that particular section was ever reached by your code before anyway. Initialize your WIN to zero and just remove all the red bits of code. They are redundant anyway.

  6. #6
    Registered User
    Join Date
    Apr 2008
    Posts
    19
    That is precisely what I did and it has worked brilliantly. Thank you for your help.

Popular pages Recent additions subscribe to a feed

Similar Threads

  1. problem w/ color functions && win98 :P
    By DarkMortar in forum C Programming
    Replies: 2
    Last Post: 06-07-2006, 04:45 PM
  2. Nested Loop problem
    By chead in forum C Programming
    Replies: 7
    Last Post: 01-03-2005, 11:47 PM
  3. Basic Math Problem. Undefined Math Functions
    By gsoft in forum C Programming
    Replies: 1
    Last Post: 12-28-2004, 02:14 AM
  4. Nested For Loops
    By smitsky in forum C++ Programming
    Replies: 2
    Last Post: 11-28-2004, 12:58 PM
  5. nested for loops and bank account interest help!!
    By webvigator2k in forum C++ Programming
    Replies: 1
    Last Post: 04-07-2003, 08:03 PM

1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21