Incrementing array index in a node.

I have a struct like so:

Code:

---

struct array {
  char *array;
  AR next;
}

---

In another function, I have declared a variable k.

To increment the array index can I do:

Code:

---

current->array[k];

---

?

I'm getting segmentation faults, so I'm thinking it's probably to do with that, so maybe I need to declare k in the struct and call it like this?

Code:

---

current->array[current->k++];

---

?

But then when I do that it says I haven't declared next and k, which is strange =(

Also, can someone tell me what is wrong with this statement? It seems to segfault here:

Code:

---

while(current->array[current->k] != '\0') {

---

The same happens when I just have k instead of current->k

Code:

---

current->array[k]

---

doesn't do anything at all. It accesses array, says "oh that's a character" and ... that's it.

I'm guessing you want

Code:

---

current->array[++k]

---

which does the same "access array and not care about it" as before, but adds 1 to k before doing so.

There is no field k in your array structure, so that code does not compile.

I don't think I described in my first post too well.

Code:

---

struct string {
  char *array;
  AR next;
  int k;
};

---

Code:

---

while(current != NULL) {
    while(current->array[current->k] != '\0') {
      string[i] = current->array[current->k];
      i++;
      current->k = current->k++;
    }
    current->k = 0;
    string[i] = '\n';
    i++;
    current = current->next;
  }

---

current->k++ increments k, it doesn't need to be assigned back to itself.

Guesses: (1) current->k doesn't get initialized before the start. (2) You inadvertently set current->array to a non-null-terminated sequence of characters, so you just keeep walking and walking and walking and walking.... (3) your struct string and "AR" are not equivalent, so following a next pointer fails. (4) i doesn't get reset to 0 in string -- although if you're writing a tokeniser that's probably the way it's supposed to be.

Quote:

---

Originally Posted by tabstop

current->k++ increments k, it doesn't need to be assigned back to itself.

Guesses: (1) current->k doesn't get initialized before the start. (2) You inadvertently set current->array to a non-null-terminated sequence of characters, so you just keeep walking and walking and walking and walking.... (3) your struct string and "AR" are not equivalent, so following a next pointer fails. (4) i doesn't get reset to 0 in string -- although if you're writing a tokeniser that's probably the way it's supposed to be.

---

I figured it out, I had cleared the array earlier with another function, hence the segfault. Thanks for your help.

Also, k does not need to be part of your struct for it to work.

Quote:

---

Originally Posted by Elysia

Also, k does not need to be part of your struct for it to work.

---

That's true, I had tried it within the function itself earlier but I was playing around trying to see what the segfault was.