problems with scanf/if statement plz help

**dezz101** · 03-20-2008

Hey Im new to programming and Im trying to creat a program, you should be able to see what Im trying to do with this sample code I have included. I know theres something wrong with my if statement but I cant figure it out... would appreciate the help guys thanx.

Heres my code
insert

Code:

#include <stdio.h>

int main()
{
	char choice;
	
	printf("Type your choice, either A, B or C\n");
	scanf("%c", &choice);
	if (choice = "%c", A)
		printf("Your choice was A");
	if (choice = "%c", B)
		printf("Your choice was B");
	if (choice = "%c", C)
		printf("Your choice was C");
	if (currency != A, B, C)
		printf("You did not choose A, B or C");

	return 0;
}

Thanx again everyone

**matsp** · 03-20-2008

Probably want

Code:

if (choice == 'A') ...

--
Mats

**Elysia** · 03-20-2008

The syntax for IF is:
if (expression [comparison] condition)
Expression is typically a variable, in your case "choice".
Comparison is an operator for comparison, such as == (equal to), != (not equal to), >, <, and so on.
And condition is what you want it to be compared against (the contents of the variable).
Characters must be surrounded with '' (single quotes) and strings must be surrounded with "" (double quotes).

= is used for assigning and not comparing. Your code should be:

Code:

	if (choice == 'A')
		printf("Your choice was A");
	else if (choice == 'B')
		printf("Your choice was B");
	else if (choice == 'C')
		printf("Your choice was C");
	else
		printf("You did not choose A, B or C");

And since you only want one condition to be true, it's better to use if and else if. That means it won't try the rest of the conditions if the one above is true. Basically if "choice equals A, if not, then if it equals B", and so on.
The last one can simple be "else" to indicate "if none of the above conditions were true".

**joker_tony** · 03-20-2008

Code:

#include<stdio.h>
#include<conio.h>
#include<stdlib.h>

int main()
{
	char choice;
	
	printf("Type your choice, either A, B or C\n");
	scanf("&#37;c", &choice);
	if (choice == 'A')
		printf("Your choice was A");
	else if (choice ==  'B')
		printf("Your choice was B");
	else if (choice == 'C')
		printf("Your choice was C");
	
	else 
		printf("You did not choose A, B or C");

    getch();
	return 0;
}

**vart** · 03-20-2008

you should use code tags when posting
and - better remove conio.h and getch as they are not standard

**Anuradh_a** · 03-21-2008

hi dezz101

you can do it simply by using Switch statement.

Code:

#include <stdio.h>

int main()
{
	char choice;
	
	printf("Type your choice, either A, B or C\n");
	scanf("&#37;c", &choice);


	switch(choice){
	case 'A':
	printf("Your choice was A");
	break;

	case 'B':
	printf("Your choice was B");
	break;
	
	case 'C':
	printf("Your choice was C");
	break;

	default:
	printf("You did not choose A, B or C");
	break;
}
	

	return 0;
}

**dezz101** · 03-25-2008

Thank you all!, it worked fine much appreciative
especially Elysia you explained it beautifully

One last querie though, at the end of my program I need it to say "Press [Enter] to exit..." and then the user presses enter andit exits but I cant figure out how to do it iv tried":

printf("Press [Enter] to exit");
fflush(stdin);
scanf("\n");
Return 0;
}

the \n is all I can think of to get it to work but is obviously doesnt

Thanks again for the help and not mocking me lol cheers.

**sreeramu** · 03-25-2008

Hi how it ip possible to do this

Code:

char choice;
scanf("%c",&choice);

i think it is not the correct way to use scanf with character data type...

**vart** · 03-25-2008

fflush(stdin);

do not flush stdin - read FAQ

also read FAQ "How can I stop my console window from disapearing"

do not forget that the previous scanf("%c") leaves the \n char in the input stream

Hi how it ip possible to do this

as it is written. What is your problem with it?

**dezz101** · 03-26-2008

I know how to make it pause and wait for a character, but I need it to print: "Press [Enter] to exit" then pause and the user only needs to press enter to exit can you show me how plz. heres my new code

Code:

#include <stdio.h>

int main()
{
	char choice;
	
	printf("Type your choice, either A, B or C\n");
	scanf("%c", &choice);
	if (choice == 'A')
		printf("Your choice was A");
	else if (choice == 'B')
		printf("Your choice was B");
	else if (choice == 'C')
		printf("Your choice was C");
	else
		printf("You did not choose A, B or C");
	printf("Press [Enter] to exit");
	scanf("\n");
	return 0;
}

That bloody last scanf is really annoying me lol. I just want to press enter and the program will exit!!!!! please can someone copy my code and then fix it the show me thanx again.

**vart** · 03-26-2008

what do you think the scanf should do?

I know how to make it pause and wait for a character

So do it instead of your strange scanf
you may want to add fflush(stdout) after printf

**matsp** · 03-26-2008

Originally Posted by dezz101

Thank you all!, it worked fine much appreciative
especially Elysia you explained it beautifully

One last querie though, at the end of my program I need it to say "Press [Enter] to exit..." and then the user presses enter andit exits but I cant figure out how to do it iv tried":

printf("Press [Enter] to exit");
fflush(stdin);
scanf("\n");
Return 0;
}

the \n is all I can think of to get it to work but is obviously doesnt

Thanks again for the help and not mocking me lol cheers.

fflush(stdin) is guaranteed to NOT work in most compilers. Check the FAQ for "Why I should not use fflush(stdin)" and "How to discard unwanted input".

--
Mats

**dezz101** · 03-30-2008

OK all is working fine I did a lil research and the getchar () function has allowed me to wait for the user to press enter b4 exiting. However I think the program would be better if, if the user did not enter a valid choice it would still printf("You did not choose A, B or C"); but then it would loop back to line 7 (printf("Type your choice, either A, B or C\n")

I know I could do it by just copy and pasting a heap of the same block of code but Im sure theres a better way to do it, plz could someone show me a easy way to do it and explain it thanx.

Code:

#include <stdio.h>

int main()
{
	char choice;
	
	printf("Type your choice, either A, B or C\n");
	scanf("%c", &choice);
	if (choice == 'A')
		printf("Your choice was A");
	else if (choice == 'B')
		printf("Your choice was B");
	else if (choice == 'C')
		printf("Your choice was C");
	else
		printf("You did not choose A, B or C");
	fflush(stdin);
	getchar ();

	return 0;
}

**dwks** · 03-30-2008

Don't use fflush(stdin)! That's what everyone is telling you, so maybe it's true, right?

Here are some links that you should read (some of which, I should mention, have already been mentioned):

**dezz101** · 03-30-2008

Alright I didnt need that and it still works, its just that thats all I been tought so far Im sure Il be tought why I shouldnt use it later on but it works with my real program.

but could we plz consentrate on the looping as i described before that is what I really need. thanx

Code:

#include <stdio.h>

int main()
{
	char choice;
	
	printf("Type your choice, either A, B or C\n");
	scanf("&#37;c", &choice);
	if (choice == 'A')
		printf("Your choice was A");
	else if (choice == 'B')
		printf("Your choice was B");
	else if (choice == 'C')
		printf("Your choice was C");
	else
		printf("You did not choose A, B or C");
	getchar ();

	return 0;
}

Thread: problems with scanf/if statement plz help

Thread Tools

Search Thread

Display

problems with scanf/if statement plz help

last problem

Similar Threads

Switch statement

Problems with GetAsyncKeyState

C Pointers Problems

String Manipulation problems -_-

Rendering problems (DirectX?)