Static definition of variables

I have this:

Code:

int main() {

int b;
b=1

sumb();
}

void sumb() {
b+=3;}

But in sumb function i get the error that b is not declared (first time in use). How can i solve this?

Thanks!

Pass the address of b to sumb as an argument, then change b += 3 to *b += 3.

Originally Posted by laserlight

Pass the address of b to sumb as an argument, then change b += 3 to *b += 3.

Isn't there another way?

Isn't there another way?

You could pass b by value, add 3, then return the result.

You could also make b a global variable, but I would recommend that you do not do that.

Originally Posted by laserlight

You could pass b by value, add 3, then return the result.

You could also make b a global variable, but I would recommend that you do not do that.

Why not?
(im very new to C, so sorry for some very dumb question i may ask).

Why not?

They make it more difficult to reason about your program and maintain it. For example, if b was a global:

• b could be changed from anywhere, especially where the change was least expected.
• It is less obvious that b is an input variable of sumb() than if it were passed as an argument.
• Functions that manipulate global variables can be less reusable, e.g., sumb() could only ever to used to sum b (which is probably what you were thinking when you named it sumb).
• Renaming b means having to rename it everywhere.

Originally Posted by laserlight

They make it more difficult to reason about your program and maintain it. For example, if b was a global:

• b could be changed from anywhere, especially where the change was least expected.
• It is less obvious that b is an input variable of sumb() than if it were passed as an argument.
• Functions that manipulate global variables can be less reusable, e.g., sumb() could only ever to used to sum b (which is probably what you were thinking when you named it sumb).
• Renaming b means having to rename it everywhere.

In this case that's exactly what i want, a unique function just for controlling b and nothing more.

How and where should i define the globals? Outside main()?

In this case that's exactly what i want, a unique function just for controlling b and nothing more.

Why?

How and where should i define the globals? Outside main()?

Yes, and not in any other function or struct.

Originally Posted by laserlight

Why?

Because it is a specific function to change some specific variables in a unique way.
b in this case works like an increment to a pointer i'm using, i wont have another pointers so i like to write sumb() when calling the function instead of sumb(b).
And the name tells me what var is changed sumb.


Thanks!

And the name tells me

keyword here is ME... It tells noone else...

When someone sees the code

Code:

sumb();

He has no idea what is goiing on inside the function

When someone sees the code

Code:

sumb(&b);

He can suppose that b is modified inside

when someone sees the code

Code:

b=Sumb(b);

He knows for sure that b is modified here

Of course - giving b a talking name, and naming sumb in some reasonable way will also help...

Because it is a specific function to change some specific variables in a unique way.

You may be better off not writing a function at all, since this all so unique.

b in this case works like an increment to a pointer i'm using, i wont have another pointers so i like to write sumb() when calling the function instead of sumb(b).

Using a global variable to avoid another level of indirection is probably a Bad Thing. There may be other, better, solutions. What exactly are you really trying to do?

Originally Posted by vart

keyword here is ME... It tells noone else...

When someone sees the code

Code:

sumb();

He has no idea what is goiing on inside the function

When someone sees the code

Code:

sumb(&b);

He can suppose that b is modified inside

when someone sees the code

Code:

b=Sumb(b);

He knows for sure that b is modified here

Of course - giving b a talking name, and naming sumb in some reasonable way will also help...

You're right but i'm just learning, this code i'm doing will not be seen by anyone else :P
Its just a way for me to know all possible ways of doing a function, even the useless ways like this one.

You're right but i'm just learning, this code i'm doing will not be seen by anyone else :P
Its just a way for me to know all possible ways of doing a function, even the useless ways like this one.

Why learn bad habits?

Originally Posted by laserlight

Why learn bad habits?

I'm not learning bad habits, i'm learning bad ways to do things, and i'm learning the good ways too. But you never know when a bad way may be your only way to do something.
Has i said before, i wont use this method often, so i'm not learning bad habits.