Thread: Uniqueness

i am trying to figure out if the number entered are unique (they havent been entered yet).
this is what i have so far
where do i go from here

Code:

#include <stdio.h>
#include <stdlib.h>

#define TRUE 1
#define FALSE 0

#define SIZE 5

//prototype
int isValid(input);


main(){

	int values [SIZE]={0};
	int count;
	int i;
	int valid;
	int result;
	int validSoFar;
	int unique;
	int uniqueSoFar;
	count=0;
	result=0;
	i=0;
	validSoFar=0;
	uniqueSoFar=0;

	for (i=0; i<SIZE; i++){
		printf("Enter an integer (50-100):\n");
		scanf("%i",&values[i]);
		valid =isValid(values[i]);
		unique=isUnique(values);
	
		if (valid ==FALSE){
			i--;}
		
		validSoFar+=valid;
		uniqueSoFar+=unique;

	
		printf("so far valid %i\n",validSoFar);
		printf("Unique so far %i\n",uniqueSoFar);
	}

	system("pause");
}

int isValid(int input){
	int result;
	int i;
	if (input>=50 && input <=100)
		result= TRUE;

	else 
		result= FALSE;
	return result;
}

int isUnique (int values[], int elements){
	int result;
	int i;
	for (i=0; i<5; i++){
		if (elements==values[i])
			result=FALSE;
		else
			result=TRUE;
	}
	return result;
}

i put in the prototype and now i have the following.
when the program runs and i put the same number in twice it still says that its unique.
how do i fix that

Code:

#include <stdio.h>
#include <stdlib.h>

#define TRUE 1
#define FALSE 0

#define SIZE 5

//prototype
int isValid(input);
int isUnique(input);

main(){

	int values [SIZE]={0};
	int count;
	int i;
	int valid;
	int result;
	int validSoFar;
	int unique;
	int uniqueSoFar;
	count=0;
	result=0;
	i=0;
	validSoFar=0;
	uniqueSoFar=0;

	for (i=0; i<SIZE; i++){
		printf("Enter an integer (50-100):\n");
		scanf("&#37;i",&values[i]);
		valid =isValid(values[i]);
		unique=isUnique(values[i]);
	
		if (valid ==FALSE){
			i--;}
		
		validSoFar+=valid;
		uniqueSoFar+=unique;

	
		printf("so far valid %i\n",validSoFar);
		printf("Unique so far %i\n",uniqueSoFar);
	}

	system("pause");
}

int isValid(int input){
	int result;
	int i;
	if (input>=50 && input <=100)
		result= TRUE;

	else 
		result= FALSE;
	return result;
}

int isUnique (int values[], int elements){
	int result;
	int i;
	for (i=0; i<5; i++){
		if (elements==values)
			result=FALSE;
		else
			result=TRUE;
	}
	return result;
}

This program shouldn't compile, at least not without a pile of warnings:

Code:

if (elements==values)

doesn't do what you think it does; and in fact nothing in your loop depends on i so I would bet this loop gets optimized away.

But even after that, your function should be called CompareToZero, since that's what it does. Trace it out on paper, and you should get an idea of what your function does and what it's supposed to do.

Consider your for loop --- what is the value of "i" when you call the isUnique() function?

And in your isUnique() function, you are not checking the entire values array are you (if elements == values)? Don't you want a subscript.?

Take another look at how you pass arrays to a function. That may help you clear this up.

Unhandled exception at 0x00413156 in Assignment 6.exe: 0xC0000005: Access violation reading location 0x00000043.
what does that mean
this is the error i keep getting and here is the updated code

Code:

#include <stdio.h>
#include <stdlib.h>

#define TRUE 1
#define FALSE 0

#define SIZE 5

//prototype
int isValid(input);
int isUnique(input);

main(){

	int values [SIZE]={0};
	int count;
	int i;
	int valid;
	int result;
	int validSoFar;
	int unique;
	int uniqueSoFar;
	count=0;
	result=0;
	i=0;
	validSoFar=0;
	uniqueSoFar=0;

	for (i=0; i<SIZE; i++){
		printf("Enter an integer (50-100):\n");
		scanf("&#37;i",&values[i]);
		valid =isValid(values[i]);
		unique=isUnique(values[i]);
	
		if (valid ==FALSE){
			i--;}
		
		validSoFar+=valid;
		uniqueSoFar+=unique;

	
		printf("so far valid %i\n",validSoFar);
		printf("Unique so far %i\n",uniqueSoFar);
	}

	system("pause");
}

int isValid(int input){
	int result;
	int i;
	if (input>=50 && input <=100)
		result= TRUE;

	else 
		result= FALSE;
	return result;
}

int isUnique (int values[], int elements){
	int result;
	int i;
	for (i=0; i<SIZE; i++){
		if (elements==values[i])
			result=FALSE;
		else
			result=TRUE;
	}
	return result;
}

This code could not compile.

Compiling: C:\Documents and Settings\Andrew\Desktop\temp.c
C:\Documents and Settings\Andrew\Desktop\temp.c:10: error: `input' was not declared in this scope
C:\Documents and Settings\Andrew\Desktop\temp.c:11: error: `input' was not declared in this scope
C:\Documents and Settings\Andrew\Desktop\temp.c:13: error: ISO C++ forbids declaration of `main' with no type
C:\Documents and Settings\Andrew\Desktop\temp.c: In function `int main()':
C:\Documents and Settings\Andrew\Desktop\temp.c:32: error: `isValid' cannot be used as a function
C:\Documents and Settings\Andrew\Desktop\temp.c:33: error: `isUnique' cannot be used as a function
C:\Documents and Settings\Andrew\Desktop\temp.c: In function `int isValid(int)':
C:\Documents and Settings\Andrew\Desktop\temp.c:49: error: `int isValid(int)' redeclared as different kind of symbol
C:\Documents and Settings\Andrew\Desktop\temp.c:10: error: previous declaration of `int isValid'
C:\Documents and Settings\Andrew\Desktop\temp.c:10: error: previous non-function declaration `int isValid'
C:\Documents and Settings\Andrew\Desktop\temp.c:49: error: conflicts with function declaration `int isValid(int)'
C:\Documents and Settings\Andrew\Desktop\temp.c:51: warning: unused variable 'i'
C:\Documents and Settings\Andrew\Desktop\temp.c: In function `int isUnique(int*, int)':
C:\Documents and Settings\Andrew\Desktop\temp.c:60: error: `int isUnique(int*, int)' redeclared as different kind of symbol
C:\Documents and Settings\Andrew\Desktop\temp.c:11: error: previous declaration of `int isUnique'
C:\Documents and Settings\Andrew\Desktop\temp.c:11: error: previous non-function declaration `int isUnique'
C:\Documents and Settings\Andrew\Desktop\temp.c:60: error: conflicts with function declaration `int isUnique(int*, int)'
Process terminated with status 1 (0 minutes, 1 seconds)
13 errors, 1 warnings

Without knowing what your code actually is, I can't say how you've walked off the end of your array.

i did a couple of changes but it didnt help.
here is the new code

Code:

#include <stdio.h>
#include <stdlib.h>

#define TRUE 1
#define FALSE 0

#define SIZE 5

//prototype
int isValid(input);
int isUnique(input);

main(){

	int values [SIZE]={0};
	int count;
	int i;
	int valid;
	int result;
	int validSoFar;
	int unique;
	int uniqueSoFar;
	count=0;
	result=0;
	i=0;
	validSoFar=0;
	uniqueSoFar=0;

	for (i=0; i<SIZE; i++){
		printf("Enter an integer (50-100):\n");
		scanf("&#37;i",&values[i]);
		valid =isValid(values[i]);
		unique=isUnique(values[i]);
	
		if (valid ==FALSE){
			i--;}
		
		validSoFar+=valid;
		uniqueSoFar+=unique;

	
		printf("so far valid %i\n",validSoFar);
		printf("Unique so far %i\n",uniqueSoFar);
	}

	system("pause");
}

int isValid(int input){
	int result;
	int i;
	if (input>=50 && input <=100)
		result= TRUE;

	else 
		result= FALSE;
	return result;
}

int isUnique (int inputData[], int elements){
	int result;
	int i;
		if (elements==inputData)
			result=FALSE;
		else
			result=TRUE;

	return result;
}

You're fiddling. Stop. Walk around the building three times. Write a flowchart/pseudocode, as you prefer. When you're done with that, then you can look at your code again.