Thread: True / False

I am trying to make this program run until 5 numbers between 50 and 100 are entered.
What am I doing wrong?

Code:

#include <stdio.h>
#include <stdlib.h>

#define TRUE 1
#define FALSE 0

#define SIZE 5

//prototype
int isValid(input);


main(){

	int values [SIZE]={0};
	int count;
	int i;
	int valid;
	int result;
	int validSoFar;
	count=0;
	result=0;
	i=0;
	validSoFar=0;


	for (i=0; i<SIZE; i++){
		printf("Enter an integer (50-100):\n");
		scanf("%i",&values[i]);
		valid =isValid(values[i]);

if (result=FALSE){
			i--;}
		validSoFar+=valid;

		
		//unique=isUnique(values);
		printf("so far valid %i\n",validSoFar);
	}

	system("pause");
}

int isValid(int input){
	int result,i;
	if (input>=50 && input <=100)
		result= TRUE;

	else 
		result= FALSE;
	return result;
}

Your problem is in this part of the code:

Code:

if (result=FALSE){
			i--;}
		validSoFar+=valid;

See if you can figure it out.

Originally Posted by goran00

What am I doing wrong?

if (result=FALSE)

Originally Posted by tabstop

if (result=FALSE)

That's not the whole problem though.

if (result=FALSE)

That's better.

i have tried using valid instead of result and 0instead of false, but its still not working.

Originally Posted by goran00

i have tried using valid instead of result and 0instead of false, but its still not working.

You've got to fix the red part, too. (Using valid has the added benefit of having a chance of working, as opposed to result.)

you mean i have to fix the equal sign?

i think i got it. i used ==

== worked. thank you.
what I am trying to do now is figure out if the number entered is unique (if it hasn't been entered already).
here is what I have so far.
any hints on how to proceed.

Code:

#include <stdio.h>
#include <stdlib.h>

#define TRUE 1
#define FALSE 0

#define SIZE 5

//prototype
int isValid(input);


main(){

	int values [SIZE]={0};
	int count;
	int i;
	int valid;
	int result;
	int validSoFar;
	int unique;
	count=0;
	result=0;
	i=0;
	validSoFar=0;


	for (i=0; i<SIZE; i++){
		printf("Enter an integer (50-100):\n");
		scanf("&#37;i",&values[i]);
		valid =isValid(values[i]);
		unique=isUnique(values);
	
		if (valid ==FALSE){
			i--;}
		
		validSoFar+=valid;


	
		printf("so far valid %i\n",validSoFar);
	}

	system("pause");
}

int isValid(int input){
	int result
	int i;
	if (input>=50 && input <=100)
		result= TRUE;

	else 
		result= FALSE;
	return result;
}

int isUnique (int inputData[], int elements){
	int result;
	int i;
	for (i=0; i<5; i++){
		if (input
			result=TRUE;
		else
			result=FALSE;
		return result;
	}

i have made a couple of changes and this is what I have.
where do I go from here

Code:

#include <stdio.h>
#include <stdlib.h>

#define TRUE 1
#define FALSE 0

#define SIZE 5

//prototype
int isValid(input);


main(){

	int values [SIZE]={0};
	int count;
	int i;
	int valid;
	int result;
	int validSoFar;
	int unique;
	int uniqueSoFar;
	count=0;
	result=0;
	i=0;
	validSoFar=0;
	uniqueSoFar=0;

	for (i=0; i<SIZE; i++){
		printf("Enter an integer (50-100):\n");
		scanf("&#37;i",&values[i]);
		valid =isValid(values[i]);
		unique=isUnique(values);
	
		if (valid ==FALSE){
			i--;}
		
		validSoFar+=valid;
		uniqueSoFar+=unique;

	
		printf("so far valid %i\n",validSoFar);
		printf("Unique so far %i\n",uniqueSoFar);
	}

	system("pause");
}

int isValid(int input){
	int result;
	int i;
	if (input>=50 && input <=100)
		result= TRUE;

	else 
		result= FALSE;
	return result;
}

int isUnique (int values[], int elements){
	int result;
	int i;
	for (i=0; i<5; i++){
		if (values[i] =elements)
			result=FALSE;
		else
			result=TRUE;
	}
	return result;
}

here is the new code, but it still doesnt work

Code:

#include <stdio.h>
#include <stdlib.h>

#define TRUE 1
#define FALSE 0

#define SIZE 5

//prototype
int isValid(input);
int isUnique(input);

main(){

	int values [SIZE]={0};
	int count;
	int i;
	int valid;
	int result;
	int validSoFar;
	int unique;
	int uniqueSoFar;
	count=0;
	result=0;
	i=0;
	validSoFar=0;
	uniqueSoFar=0;

	for (i=0; i<SIZE; i++){
		printf("Enter an integer (50-100):\n");
		scanf("&#37;i",&values[i]);
		valid =isValid(values[i]);
		unique=isUnique(values[i]);
	
		if (valid ==FALSE){
			i--;}
		
		validSoFar+=valid;
		uniqueSoFar+=unique;

	
		printf("so far valid %i\n",validSoFar);
		printf("Unique so far %i\n",uniqueSoFar);
	}

	system("pause");
}

int isValid(int input){
	int result;
	int i;
	if (input>=50 && input <=100)
		result= TRUE;

	else 
		result= FALSE;
	return result;
}

int isUnique (int values[], int elements){
	int result;
	int i;
	for (i=0; i<5; i++){
		if (elements==values)
			result=FALSE;
		else
			result=TRUE;
	}
	return result;
}