Hi guys, newbie here, some questions!

You should pay attention to the warnings of th ecompiler

Code:

#include <stdio.h>
#include <string.h>

#define ALPHABET_TOTAL 26                    

int main()
{
	
	/*defining variables*/
	
	FILE *fp;                              
	
	int text[ALPHABET_TOTAL] = {0},          
		text_input,                        
		ASCII_count,                       
		alpha;                             
	
	char filename[20];
	
	
	/*initializing*/
	
	text_input = 0;   
	ASCII_count = 0;
	alpha = 0;
	
	/*user prompt*/ 
	
	printf("Type a file name, followed by the <enter> key : ");   
	
	if(fgets(filename,sizeof(filename),stdin))
	{
		char* p = strchr(filename, '\n');
		if(p) *p = '\0';
	}
	else
	{
		puts("Failed to read a file name");
		return 1;
	}
	
	fp=fopen(filename,"r");
	
	
	/*text analysis*/
	
	while( (text_input = fgetc(fp)) != EOF )   
	{
		
		if(text_input >= 'a' && text_input <= 'z')
			text_input -= 'a';
		else if(text_input >= 'A' && text_input <= 'Z')
			text_input -= 'A';
		else
			continue;

		text[text_input]++;
	}
    
	/*display results*/
    
	for (ASCII_count = 0; ASCII_count <= 25; ASCII_count++)
		printf("\nTotal &#37;c or %c: %d", ASCII_count + 'a', ASCII_count + 'A',text[ASCII_count]);

	return 0;
}

Well I tried compiling your program and I got implicit declaration of strchr, which means you didn't include some library, probably the strings library.

also it said that :

for (ASCII_count; ASCII_count <= 25; ASCII_count++)

was a statement with no effect

Well you didn't initialize this:

for (ASCII_count = 0; ASCII_count <= 25; ASCII_count++)

Whatever the value is meant to be

What compiler are you using?

Does it ask you for a filename? If not, try addding "fflush(stdout);" after the printf() asking the name.

--
Mats

I'm using the Borland C++

Yeah it does prompt me for a file name, in fact the whole thing works pretty well

Borland C++ is a pretty old, non-recommended compiler.
Try upgrading to, say, Visual Studio. Great IDE.

Ok, another quick question, more to do with the logical side of things.

Basically I've added a few lines in order to make a word count - using the number of spaces + 1, however my program seems to add to the count when it encounters punctuation too. I have no idea why!

Code:

#include <stdio.h>
#include <string.h>

#define ALPHABET_TOTAL 26                    

int main()

{
	
	/*defining variables*/
	
	FILE *fp;                              
	
	int text[ALPHABET_TOTAL] = {0},          
		text_input,                        
		ASCII_count,                       
		word_count;                             
	
	char filename[20];
	
	
	/*initializing*/
	
	text_input = 0;   
	ASCII_count = 0;
	word_count = 1;
	
	/*user prompt*/ 
	
	printf("Type a file name, followed by the <enter> key : ");   
	
	if(fgets(filename,sizeof(filename),stdin))
	{
		char* p = strchr(filename, '\n');
		if(p) *p = '\0';
	}
	else
	{
		puts("Failed to read a file name");
		return 1;
	}
	
	fp=fopen(filename,"r");
	
	
	/*text analysis*/
	
	while( (text_input = fgetc(fp)) != EOF )   
	{
		
		if(text_input >= 'a' && text_input <= 'z')
			text_input -= 'a';
		else if(text_input >= 'A' && text_input <= 'Z')
			text_input -= 'A';
                else if(text_input = ' ')
			word_count++;
              
		else
			continue;

		text[text_input]++;
	}

	printf(" Total words: %d " , word_count++);
    
	/*display results*/
    
	for (ASCII_count = 0; ASCII_count <= 25; ASCII_count++)
		printf("\n Total %c or %c: %d", ASCII_count + 'a', ASCII_count + 'A',text[ASCII_count]);

	return 0;
}

So set it to count a word only when there is a space encountered or a new line. As long as you don't do this:

hi , ok

it will work fine

That's what I thought I'd done...

Code:

else if(text_input = ' ')
			word_count++;

seems to add to the count when it encounters punctuation too. I have no idea why!

Why do you think so?
Show your input and the output

Code:

else if(text_input == ' ')

Turn up them warnings. Some compilers warn about that.
Single = is assign and double == is compare.

Originally Posted by Elysia

Code:

else if(text_input == ' ')

Turn up them warnings. Some compilers warn about that.
Single = is assign and double == is compare.

aha!

Thanks!

Ok, another one

Trying to print the 'average word length' which I'm trying to define as total characters/total words

Do all of these variables need to be defined as doubles from the offset?

Code:

#include <stdio.h>
#include <string.h>

#define ALPHABET_TOTAL 26                    

int main()

{
	
	/*defining variables*/
	
	FILE *fp;                              
	
	int text[ALPHABET_TOTAL] = {0},          
		text_input,                        
		ASCII_count;
        double  letter_count,                       
		word_count,
                word_average;                             
	
	char filename[20];
	
	
	/*initializing*/
	
	text_input = 0;   
	ASCII_count = 0;
        letter_count = 0;
	word_count = 1;
        word_average = 0;
	
	/*user prompt*/ 
	
	printf("Type a file name, followed by the <enter> key : ");   
	
	if(fgets(filename,sizeof(filename),stdin))
	{
		char* p = strchr(filename, '\n');
		if(p) *p = '\0';
	}
	else
	{
		puts("Failed to read a file name");
		return 1;
	}
	
	fp=fopen(filename,"r");
	
	
	/*text analysis*/
	
	while( (text_input = fgetc(fp)) != EOF )   
	{
		
		if(text_input >= 'a' && text_input <= 'z')
			text_input -= 'a',
                        letter_count++;
		else if(text_input >= 'A' && text_input <= 'Z')
			text_input -= 'A',
                        letter_count++;
                else if(text_input == ' ')
			word_count++;
              
		else
			continue;

		text[text_input]++;

	}

        word_average = letter_count/word_count;


/*display results*/

	printf(" Average word length: %d ", word_average);
    
	
    
	for (ASCII_count = 0; ASCII_count <= 25; ASCII_count++)
		printf("\n Total %c or %c: %d", ASCII_count + 'a', ASCII_count + 'A',text[ASCII_count]);

	return 0;
}

No, they don't need to be doubles because you're not using decimals.

Code:

		if(text_input >= 'a' && text_input <= 'z')
			text_input -= 'a',
                        letter_count++;
		else if(text_input >= 'A' && text_input <= 'Z')
			text_input -= 'A',
                        letter_count++;

Should be

Code:

		if(text_input >= 'a' && text_input <= 'z')
		{
			text_input -= 'a';
                        letter_count++;
		}
		else if(text_input >= 'A' && text_input <= 'Z')
		{
			text_input -= 'A';
                        letter_count++;
		}

{ marks the beginning of a block and } marks the end, just like your function.

When I define the variables as ints, the &#37;d is rounded to a whole number in the printf call, why is it doing that?