Thread: Why doesn't this work? while ( searchPtr = strstr( searchPtr + 1, searchString ) )

The if structure is similar and seems to work just fine. The program completely skips over the while structure though.

Is this an appropriate way to use conditional structures? I imagine this could be considered poorly readable code but I wouldn't know.

Code:

/*
8.16
Write a program that inputs a line of text and a search string from the 
keyboard.  Using function strstr, locate the first occurrence of the search 
string in the line of text, and assign the location to variable searchPtr of
type char *.  If the search string is found, print the remainder of the line of
text beginning with the search string.  Then, use strstr again to locate the 
next occurrence of the search strig in the line of text.  If a second occurrene
is found, print the remainder of the line of text begiining with the seond 
occurrence.  (Hint: The second call to strstr should contain searchPtr + 1 as 
its first argument. )
*/
#include <stdio.h>
#include <string.h>

int main()
{
  char *searchPtr;
  char bulk[ 100 ] = { };
  char searchString[ 100 ] = { };

  printf( "Enter the initial string: " );
  scanf( "&#37;s", bulk );

  printf( "Enter string to search for: " );
  scanf( "%s", searchString );


  if ( searchPtr = strstr( bulk, searchString ) ) {
    printf( "%s\n", searchPtr );
    
    while ( searchPtr = strstr( searchPtr + 1, searchString ) ) {
      printf( "%s\n", searchPtr );
    }
    
  }

  // Test commands below to pinpoint problem
  //searchPtr = strstr( searchPtr + 1, searchString );
  //printf( "%s\n", searchPtr );

  return 0;
}

You're not expecting scanf to read in a string with spaces in it, are you?

No, I've been using stuff like "abcdefsomethingdefhellodefdef

Originally Posted by yougene

No, I've been using stuff like "abcdefsomethingdefhellodefdef

Then it works. (No really, I just compiled it and tried it.)

Works for me too. You might need some getchars to keep the window open?

I should have included my commandline output

Apparently if there are alot of matches it'll find some of them but not all.

Code:

root[~]# ./a.out
Enter the initial string: abcdefsomethingdefhellodefdef
Enter string to search for: def
defsomethingdefhellodefdef
defhellodefdef
root[~]#

I still get

Code:

silverlx:~$ ./a.out
Enter the initial string: abcdefsomethingdefhellodefdef
Enter string to search for: def
defsomethingdefhellodefdef
defhellodefdef
defdef
def

Are you sure you don't need to recompile or something? Because the source code you've shown is right.

Hmm, for some reason recompiling did work. Maybe I didn't get emacs to save last time I ran it. : \

I apologize for the brainfart.