Function call another function

[sixstringsgaret]

How do you call a function in a function?

This is the function:

int comStaRatio(int comments, int statements)
{
    int ratio=1;
    
    ratio=comments/statements;
    
    return(ratio);
}

comments and statements will be two other functions both returning int values.
So when called I will do:

printf("Comment to statement ratio: %d\n", comStaRatio(comCount(file_pointer), staCount(file_pointer)));

but this doesn't work. Why?

Thanks.

[laserlight]

How does it not work?

[sixstringsgaret]

I'm unsure, but it returns 0.

[laserlight]

I'm unsure, but it returns 0.

That sounds okay, if the result of comCount(file_pointer) is less than the result of staCount(file_pointer).

[slingerland3g]

printf("Comment to statement ratio: %d\n", comStaRatio(comCount(file_pointer), staCount(file_pointer)));

First you are missing your second argument to printf. How are you to use staCount()?

[Thantos]

Well what are the values of comments and statements in the function?

[slingerland3g]

crap never mind my last post!

[slingerland3g]

After actually looking more closer, your %d qualifier should be %f.

If your division is less than 0, that is what you will get. What level of precision are you needing with this calculation?

[sixstringsgaret]

laserlight you are a legend! I can;t believe i was so stupid not to realise that the answer actually is 0!!!

Thank you!

[sixstringsgaret]

Uh oh. Whenever I try to change the function and the function call to float it doesnt work!

float comStaRatio(int comments, int statements)
{
    float ratio=1;
    
    ratio=(float)comments/(float)statements;
    
    return(ratio);
}

Call:

printf("Comment to statement ratio: %.2f\n", comStaRatio(comCount(file_pointer), staCount(file_pointer)));

Any ideas?

[mike_g]

printf("Comment to statement ratio: %.2f\n", comStaRatio(comCount(file_pointer), staCount(file_pointer)));

See something that dosent match?

Edit: Ignore it does >_<

[sixstringsgaret]

No I can't say that I do.
The two parameters you have in green are ints yes but comStaRatio returns a floating point number.

[laserlight]

Uh oh. Whenever I try to change the function and the function call to float it doesnt work!

It looks okay to me. I suggest that you post the smallest and simplest compilable code that demonstrates the problem.

See something that dosent match?

Nope.

[Prelude]

>See something that dosent match?
No, I don't. Perhaps you could elaborate on what you think is wrong.

[mike_g]

Yeah I edited my post. I just read the brackets wrong o_0